mirror of
https://github.com/gradle/actions.git
synced 2026-08-17 19:32:52 +00:00
9d31058114
## Why Issue #1013 revealed that caching was **never storing content on Windows**. Nothing caught it because the integ-tests lost their multi-OS matrices: these workflows used to default to `'["ubuntu-latest", "windows-latest", "macos-latest"]'`, narrowed to ubuntu-only inbcd07e66/d74ee73e(Aug 2024). The Windows code path has been dark ever since. ## What Extract the two cheapest caching tests — `restore-gradle-home` and `basic-cache-provider` — into a new `suite-smoke-test-caching` workflow, and run that suite on both `ubuntu-latest` and `windows-latest`. Both tests seed a cache in one job and then verify it in a dependent job with an `--offline` build, so a cache that stores nothing fails the verify job rather than passing silently. - Rename `integ-test-{restore-gradle-home,basic-cache-provider}` → `smoke-test-*` and drop them from `suite-integ-test-caching` - Add the new suite to both `CI-integ-test` and `CI-integ-test-full`, each with its own concurrency group matching the sibling suites - Include `smoke-tests` in the `integ-test-success` aggregate gate - Ignore the generated `task-configured.txt` marker in `workflow-samples` - Drop a dead `needs.determine-suite` guard on the `build-distribution` step — `CI-integ-test` has no such job, so it always evaluated to true The suite runs on Windows in PR CI (not just `CI-integ-test-full`) specifically so the failure is visible on this PR and the fix can be verified the same way. ## Expected result This PR is expected to be **red on Windows**. `restore-gradle-home-dependencies-cache` and `basic-cache-verify-build` should fail with dependency-resolution errors under `--offline` — that is the bug from #1013 being caught. The ubuntu legs should stay green. Cross-OS cache keys are safe: both providers include `RUNNER_OS` in the key (`sources/src/cache-service-basic.ts:146`), so the matrix legs don't collide. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
93 lines
2.8 KiB
YAML
93 lines
2.8 KiB
YAML
name: CI-integ-test
|
|
|
|
on:
|
|
workflow_dispatch:
|
|
pull_request:
|
|
push:
|
|
branches:
|
|
- 'main'
|
|
- 'release/**'
|
|
- 'dev/**' # Allow running tests on dev branches without a PR
|
|
paths-ignore:
|
|
- 'dist/**'
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
build-distribution:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout sources
|
|
uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
|
|
- name: Build and upload distribution
|
|
uses: ./.github/actions/build-dist
|
|
|
|
smoke-tests:
|
|
needs: build-distribution
|
|
uses: ./.github/workflows/suite-smoke-test-caching.yml
|
|
concurrency:
|
|
group: CI-smoke-test-caching-${{ github.ref }}
|
|
cancel-in-progress: false
|
|
with:
|
|
skip-dist: false
|
|
runner-os: '["ubuntu-latest", "windows-latest"]'
|
|
secrets: inherit
|
|
|
|
caching-integ-tests:
|
|
needs: build-distribution
|
|
uses: ./.github/workflows/suite-integ-test-caching.yml
|
|
concurrency:
|
|
group: CI-integ-test-caching-${{ github.ref }}
|
|
cancel-in-progress: false
|
|
with:
|
|
skip-dist: false
|
|
secrets: inherit
|
|
|
|
other-integ-tests:
|
|
permissions:
|
|
contents: write
|
|
needs: caching-integ-tests
|
|
uses: ./.github/workflows/suite-integ-test-other.yml
|
|
concurrency:
|
|
group: CI-integ-test-other-${{ github.ref }}
|
|
cancel-in-progress: false
|
|
with:
|
|
skip-dist: false
|
|
secrets: inherit
|
|
|
|
dependency-submission-integ-tests:
|
|
permissions:
|
|
contents: write
|
|
needs: other-integ-tests
|
|
uses: ./.github/workflows/suite-integ-test-dependency-submission.yml
|
|
concurrency:
|
|
group: CI-integ-test-dependency-submission-${{ github.ref }}
|
|
cancel-in-progress: false
|
|
with:
|
|
skip-dist: false
|
|
secrets: inherit
|
|
|
|
# Aggregate gate: a single check that succeeds only when all integ-test jobs succeed.
|
|
# Require this one check in branch protection instead of every fanned-out matrix job.
|
|
integ-test-success:
|
|
if: ${{ always() }}
|
|
needs:
|
|
- build-distribution
|
|
- smoke-tests
|
|
- caching-integ-tests
|
|
- other-integ-tests
|
|
- dependency-submission-integ-tests
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Fail if any integ-test job failed or was cancelled
|
|
if: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }}
|
|
run: |
|
|
echo "One or more integ-test jobs did not succeed:"
|
|
echo " build-distribution: ${{ needs.build-distribution.result }}"
|
|
echo " smoke-tests: ${{ needs.smoke-tests.result }}"
|
|
echo " caching-integ-tests: ${{ needs.caching-integ-tests.result }}"
|
|
echo " other-integ-tests: ${{ needs.other-integ-tests.result }}"
|
|
echo " dependency-submission-integ-tests: ${{ needs.dependency-submission-integ-tests.result }}"
|
|
exit 1
|